fix: Refactor WebSocketSubscription and remove unused code

neet · neet · commit 6870df2bae6a · 2024-05-03T22:36:28.000+09:00
diff --git a/src/adapters/ws/web-socket-subscription.ts b/src/adapters/ws/web-socket-subscription.ts
@@ -26,8 +26,6 @@ export class WebSocketSubscription implements mastodon.streaming.Subscription {
     while (this.connector.canAcquire()) {
       this.connection = await this.connector.acquire();
 
-      const messages = toAsyncIterable(this.connection);
-
       const data = this.serializer.serialize("json", {
         type: "subscribe",
         stream: this.stream,
@@ -37,8 +35,15 @@ export class WebSocketSubscription implements mastodon.streaming.Subscription {
       this.logger?.log("debug", "↑ WEBSOCKET", data);
       this.connection.send(data);
 
-      for await (const event of this.transformIntoEvents(messages)) {
-        if (!this.matches(event)) continue;
+      const messages = toAsyncIterable(this.connection);
+
+      for await (const message of messages) {
+        const event = await this.parseMessage(message.data as string);
+
+        if (!this.test(event)) {
+          continue;
+        }
+
         this.logger?.log("debug", "↓ WEBSOCKET", event);
         yield event;
       }
@@ -70,7 +75,7 @@ export class WebSocketSubscription implements mastodon.streaming.Subscription {
     this.unsubscribe();
   }
 
-  private matches(event: mastodon.streaming.Event): boolean {
+  private test(event: mastodon.streaming.Event): boolean {
     // subscribe("hashtag", { tag: "foo" }) -> ["hashtag", "foo"]
     // subscribe("list", { list: "foo" })   -> ["list", "foo"]
     const params = this.params ?? {};
@@ -79,15 +84,6 @@ export class WebSocketSubscription implements mastodon.streaming.Subscription {
     return stream.every((s) => event.stream.includes(s));
   }
 
-  private async *transformIntoEvents(
-    messages: AsyncIterable<WebSocket.MessageEvent>,
-  ) {
-    for await (const message of messages) {
-      const event = await this.parseMessage(message.data as string);
-      yield event;
-    }
-  }
-
   private async parseMessage(
     rawEvent: string,
   ): Promise<mastodon.streaming.Event> {
diff --git a/src/utils/exponential-backoff.ts b/src/utils/exponential-backoff.ts
@@ -25,7 +25,7 @@ export class ExponentialBackoff {
       throw new ExponentialBackoffError(this.attempts);
     }
 
-    await sleep(this.getTimeout());
+    await sleep(this.timeout);
     this.attempts++;
   }
 
@@ -45,7 +45,7 @@ export class ExponentialBackoff {
     return this.props.maxAttempts ?? Number.POSITIVE_INFINITY;
   }
 
-  getTimeout(): number {
+  private get timeout(): number {
     return this.factor * this.base ** this.attempts;
   }
 }
diff --git a/src/utils/noop.ts b/src/utils/noop.ts
@@ -1,7 +1,3 @@
 export function noop(): void {
   //
 }
-
-export async function noopAsync(): Promise<void> {
-  //
-}

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ export class ExponentialBackoff {`
`25`	`25`	`throw new ExponentialBackoffError(this.attempts);`
`26`	`26`	`}`
`27`	`27`
`28`		`- await sleep(this.getTimeout());`
	`28`	`+ await sleep(this.timeout);`
`29`	`29`	`this.attempts++;`
`30`	`30`	`}`
`31`	`31`
`@@ -45,7 +45,7 @@ export class ExponentialBackoff {`
`45`	`45`	`return this.props.maxAttempts ?? Number.POSITIVE_INFINITY;`
`46`	`46`	`}`
`47`	`47`
`48`		`- getTimeout(): number {`
	`48`	`+ private get timeout(): number {`
`49`	`49`	`return this.factor * this.base ** this.attempts;`
`50`	`50`	`}`
`51`	`51`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,3 @@`
`1`	`1`	`export function noop(): void {`
`2`	`2`	`//`
`3`	`3`	`}`
`4`		`-`
`5`		`-export async function noopAsync(): Promise<void> {`
`6`		`- //`
`7`		`-}`