Skip to content

Export missing v1 entity types: QuoteApproval, AccountWarning, Appeal#1395

Merged
neet merged 4 commits into
mainfrom
copilot/fix-quote-approval-export-error
Jan 2, 2026
Merged

Export missing v1 entity types: QuoteApproval, AccountWarning, Appeal#1395
neet merged 4 commits into
mainfrom
copilot/fix-quote-approval-export-error

Conversation

Copilot AI commented Jan 2, 2026

Copy link
Copy Markdown
Contributor

Plan: Export Missing v1 Entity Types

  • Identify all missing exports in src/mastodon/entities/v1/index.ts
  • Add export statements for quote-approval.ts, account-warning.ts, and appeal.ts
  • Build the project to ensure no TypeScript errors
  • Run type checks and all unit tests - all passing
  • Fix linting issues - all checks passing
  • Remove unnecessary test file per maintainer feedback

Summary

Fixed the issue where mastodon.v1.QuoteApproval, mastodon.v1.AccountWarning, and mastodon.v1.Appeal types were not exported from the package. Users can now access these types directly via the mastodon.v1 namespace instead of importing from internal paths like masto/dist/esm/mastodon/entities/v1/quote-approval.

Changes:

  • Added three missing type exports to src/mastodon/entities/v1/index.ts
  • Removed unit test file per maintainer feedback (e2e tests are for REST API behavior)
  • All existing tests pass
  • All linting and type checks pass
Original prompt

This section details on the original issue you should resolve

<issue_title>no exported member 'QuoteApproval'</issue_title>
<issue_description>apologies if this is a dumb issue but I extend mastodon.v1.Status in fedialgo and so I need to match the underlying types, but when I go to create a field of type mastodon.v1.QuoteApproval i get an error.

i can fix this by adding:

import { QuoteApproval } from "masto/dist/esm/mastodon/entities/v1/quote-approval";

but that seems less than ideal.</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits January 2, 2026 01:44
…peal

Co-authored-by: neet <19276905+neet@users.noreply.github.com>
Co-authored-by: neet <19276905+neet@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix no exported member 'QuoteApproval' issue Export missing v1 entity types: QuoteApproval, AccountWarning, Appeal Jan 2, 2026
Copilot AI requested a review from neet January 2, 2026 01:51
@neet

neet commented Jan 2, 2026

Copy link
Copy Markdown
Owner

@copilot Looks great but I think you don't need to add tests for them as tests under the e2e directory are dedicated for checking REST API behaviour.

Co-authored-by: neet <19276905+neet@users.noreply.github.com>

Copilot AI commented Jan 2, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Looks great but I think you don't need to add tests for them as tests under the e2e directory are dedicated for checking REST API behaviour.

Removed the test file in 422cb9e. The type exports are now in place without the unnecessary unit tests.

@neet neet marked this pull request as ready for review January 2, 2026 02:21
Copilot AI review requested due to automatic review settings January 2, 2026 02:21
@github-actions

github-actions Bot commented Jan 2, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
rest 3.9 KB (0%)
streaming 3.86 KB (0%)
oauth 3.9 KB (0%)

@pkg-pr-new

pkg-pr-new Bot commented Jan 2, 2026

Copy link
422cb9e_ " data-view-component="true" class="dropdown-item btn-link"> Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/neet/masto.js/masto@1395

commit: 422cb9e

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR resolves an issue where three v1 entity types (QuoteApproval, AccountWarning, and Appeal) were not exported from the package's public API, forcing users to import from internal distribution paths.

Key Changes:

  • Added three missing type exports to src/mastodon/entities/v1/index.ts in alphabetical order

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@neet neet merged commit bb70017 into main Jan 2, 2026
13 checks passed
@neet neet deleted the copilot/fix-quote-approval-export-error branch January 2, 2026 02:27
@neet neet mentioned this pull request Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

no exported member 'QuoteApproval'

3 participants