fix: Fix v2.media.create not working with $raw#1376
Merged
Conversation
Contributor
size-limit report 📦
|
commit: |
neet
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix an issue where v2.media.create doesn't work correctly with the $raw parameter. The fix modifies the afterDispatch method to handle HttpResponse objects and properly preserve headers when returning media attachment results.
Key Changes:
- Made
afterDispatchmethod async to properly handle awaited media attachment polling - Updated result handling to work with
HttpResponsestructure instead of raw data - Added
HttpResponsetype import to support the new typing
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
neet
force-pushed
the
fix-raw-v2-create-media
branch
2 times, most recently
from
ba22f23 to
24777d6
Compare
neet
force-pushed
the
fix-raw-v2-create-media
branch
from
24777d6 to
efbe475
Compare
neet
force-pushed
the
fix-raw-v2-create-media
branch
from
efbe475 to
baa06d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1375