Add new quote fields to status object#1354
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for quote-related fields when creating statuses, implementing issue #1353. The changes introduce two new optional parameters to CreateStatusParamsBase: quotedStatusId for referencing a quoted status, and quoteApprovalPolicy to control who can quote a status.
Key changes:
- Added
QuoteApprovalPolicyRegistryinterface andQuoteApprovalPolicytype for type-safe policy values - Added
quotedStatusIdparameter to specify the status being quoted - Added
quoteApprovalPolicyparameter to control quote permissions (public, followers, nobody)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+33
to
+36
| /** Sets who is allowed to quote the status. When omitted, the user’s default setting will be used instead. Ignored if visibility is private or direct, in which case the policy will always be set to nobody. | ||
| public = Anyone is allowed to quote this status and will have their quote automatically accepted, unless they are blocked. | ||
| followers = Only followers and the author are allowed to quote this status, and will have their quote automatically accepted. | ||
| nobody = Only the author is allowed to quote the status.*/ |
There was a problem hiding this comment.
The documentation for quoteApprovalPolicy should follow the established pattern used elsewhere in the codebase. Based on similar fields like ListRepliesPolicy, the enum values should be formatted in a multi-line JSDoc comment with:
- Each value on its own line
- Backticks around the value names
- Proper spacing with blank lines between entries
Example format:
/**
* Sets who is allowed to quote the status. When omitted, the user's default setting will be used instead. Ignored if visibility is private or direct, in which case the policy will always be set to nobody.
*
* `public` = Anyone is allowed to quote this status and will have their quote automatically accepted, unless they are blocked.
*
* `followers` = Only followers and the author are allowed to quote this status, and will have their quote automatically accepted.
*
* `nobody` = Only the author is allowed to quote the status.
*/
Suggested change
| /** Sets who is allowed to quote the status. When omitted, the user’s default setting will be used instead. Ignored if visibility is private or direct, in which case the policy will always be set to nobody. | |
| public = Anyone is allowed to quote this status and will have their quote automatically accepted, unless they are blocked. | |
| followers = Only followers and the author are allowed to quote this status, and will have their quote automatically accepted. | |
| nobody = Only the author is allowed to quote the status.*/ | |
| /** | |
| * Sets who is allowed to quote the status. When omitted, the user's default setting will be used instead. Ignored if visibility is private or direct, in which case the policy will always be set to nobody. | |
| * | |
| * `public` = Anyone is allowed to quote this status and will have their quote automatically accepted, unless they are blocked. | |
| * | |
| * `followers` = Only followers and the author are allowed to quote this status, and will have their quote automatically accepted. | |
| * | |
| * `nobody` = Only the author is allowed to quote the status. | |
| */ |
commit: |
neet
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implements #1353
I'm not sure what else needs to be done, feel flee to direct me, or take over :)