chore: Remove eslint-plugin-prettier (#1386)

neet · web-flow · commit 097a1d583551 · 2025-12-12T12:38:43.000Z
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -32,10 +32,14 @@ jobs:
       - name: Build TypeScript
         run: npm run build
 
-      - name: Run tests
+      - name: Run lint, format, spellcheck
         run: |
           npm run lint
-          npm run test:unit -- --coverage
+          npm run format
+          npm run spellcheck
+
+      - name: Run tests
+        run: npm run test:unit -- --coverage
 
       - name: Codecov
         uses: codecov/codecov-action@v4
diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml
@@ -21,7 +21,7 @@ jobs:
         with:
           # > By default, Release Please uses the built-in GITHUB_TOKEN secret.
           # > However, all resources created by release-please (release tag or release pull request) will not trigger future GitHub actions workflows,
-          # > and workflows normally triggered by release.created events will also not run. 
+          # > and workflows normally triggered by release.created events will also not run.
           # https://github.com/googleapis/release-please-action?tab=readme-ov-file#other-actions-on-release-please-prs
           token: ${{ secrets.GH_PAT }}
           release-type: node
@@ -32,7 +32,7 @@ jobs:
       - uses: actions/setup-node@v4
         with:
           node-version: "24.9.0"
-          registry-url: 'https://registry.npmjs.org'
+          registry-url: "https://registry.npmjs.org"
         if: ${{ steps.release.outputs.release_created }}
 
       - run: npm install -g npm@latest
@@ -43,4 +43,3 @@ jobs:
 
       - run: npm publish
         if: ${{ steps.release.outputs.release_created }}
-
diff --git a/.vscode/extensions.json b/.vscode/extensions.json
@@ -1,6 +1,3 @@
 {
-  "recommendations": [
-    "esbenp.prettier-vscode",
-    "dbaeumer.vscode-eslint"
-  ]
+  "recommendations": ["esbenp.prettier-vscode", "dbaeumer.vscode-eslint"]
 }
diff --git a/CHANGELOG.md b/CHANGELOG.md
diff --git a/CLAUDE.md b/CLAUDE.md
@@ -9,6 +9,7 @@ Masto.js is a universal Mastodon API client for JavaScript/TypeScript that works
 ## Development Commands
 
 ### Building
+
 ```bash
 npm run build              # Build both ESM and CJS outputs
 npm run build:esm          # Build ESM only
@@ -18,6 +19,7 @@ npm run build:cjs          # Build CJS only
 The build process uses `tsconfig-to-dual-package` to generate dual ESM/CJS outputs from separate TypeScript configs.
 
 ### Testing
+
 ```bash
 npm test                   # Run all tests (unit + e2e)
 npm run test:unit          # Run unit tests only (uses Vitest)
@@ -27,18 +29,21 @@ npm run test:e2e           # Run e2e tests only (requires Mastodon instance)
 **Important**: E2E tests require a local Mastodon instance running at `http://localhost:3000` with admin credentials (`admin@localhost` / `mastodonadmin`). The test setup automatically creates OAuth apps and tokens, caching them in `node_modules/.cache/masto/`.
 
 ### Linting
+
 ```bash
 npm run lint               # Run all linters
 npm run lint:eslint        # Run ESLint only
 npm run lint:spellcheck    # Run spellcheck only
 ```
 
 ### Documentation
+
 ```bash
 npm run docs:build         # Generate TypeDoc documentation
 ```
 
 ### Running Single Tests
+
 ```bash
 npx vitest --project unit src/path/to/file.spec.ts
 npx vitest --project e2e tests/path/to/file.spec.ts
@@ -97,11 +102,13 @@ When you call `masto.v1.statuses.create({ status: "Hello" })`:
 ## Testing Strategy
 
 ### Unit Tests (`src/**/*.spec.ts`)
+
 - Located alongside source files
 - Test individual functions and edge cases
 - Used for exception handling and logic that's hard to test E2E
 
 ### E2E Tests (`tests/**/*.spec.ts`)
+
 - Primary testing approach
 - Use real Mastodon server at `localhost:3000`
 - Leverage `sessions` global for test account management:
@@ -115,7 +122,7 @@ await session.rest.v1.statuses.create({ status: "test" });
 await using alice = await sessions.acquire();
 await using bob = await sessions.acquire();
 await alice.rest.v1.statuses.create({
-  status: `Hello @${bob.account.acct}`
+  status: `Hello @${bob.account.acct}`,
 });
 ```
 
@@ -171,11 +178,12 @@ Keep bundle size minimal - this is a key project goal tracked via size-limit in
 ### Debugging Proxy Behavior
 
 Set the `log` option when creating clients:
+
 ```typescript
 const masto = createRestAPIClient({
   url: "https://mastodon.social",
   accessToken: "...",
-  log: "debug"  // "debug" | "info" | "warn" | "error"
+  log: "debug", // "debug" | "info" | "warn" | "error"
 });
 ```
 
diff --git a/CODE_OF_CONDUCT.md b/CODE_OF_CONDUCT.md
@@ -14,22 +14,22 @@ appearance, race, religion, or sexual identity and orientation.
 Examples of behavior that contributes to creating a positive environment
 include:
 
-* Using welcoming and inclusive language
-* Being respectful of differing viewpoints and experiences
-* Gracefully accepting constructive criticism
-* Focusing on what is best for the community
-* Showing empathy towards other community members
+- Using welcoming and inclusive language
+- Being respectful of differing viewpoints and experiences
+- Gracefully accepting constructive criticism
+- Focusing on what is best for the community
+- Showing empathy towards other community members
 
 Examples of unacceptable behavior by participants include:
 
-* The use of sexualized language or imagery and unwelcome sexual attention or
- advances
-* Trolling, insulting/derogatory comments, and personal or political attacks
-* Public or private harassment
-* Publishing others' private information, such as a physical or electronic
- address, without explicit permission
-* Other conduct which could reasonably be considered inappropriate in a
- professional setting
+- The use of sexualized language or imagery and unwelcome sexual attention or
+  advances
+- Trolling, insulting/derogatory comments, and personal or political attacks
+- Public or private harassment
+- Publishing others' private information, such as a physical or electronic
+  address, without explicit permission
+- Other conduct which could reasonably be considered inappropriate in a
+  professional setting
 
 ## Our Responsibilities
 
diff --git a/cspell.json b/cspell.json
@@ -1,10 +1,7 @@
 {
   "version": "0.2",
   "language": "en,en-GB",
-  "ignorePaths": [
-    "**/node_modules/**",
-    "**/dist/**"
-  ],
+  "ignorePaths": ["**/node_modules/**", "**/dist/**"],
   "words": [
     "AGPL",
     "asynckit",
@@ -21,6 +18,7 @@
     "gifv",
     "Gmail",
     "hostsupdater",
+    "isomorphic",
     "idempotency",
     "Igarashi",
     "KeyBase",
@@ -49,8 +47,10 @@
     "unbookmark",
     "undici",
     "unendorse",
+    "unendorses",
     "unfavourite",
     "unfeature",
+    "unfeatures",
     "unfetch",
     "unfollow",
     "unprocessable",
diff --git a/eslint.config.js b/eslint.config.js
@@ -1,6 +1,8 @@
+/* eslint-disable import/no-named-as-default-member */
 import eslint from "@eslint/js";
+import { defineConfig, globalIgnores } from "eslint/config";
+import eslintConfigPrettier from "eslint-config-prettier/flat";
 import importPlugin from "eslint-plugin-import";
-import eslintPluginPrettierRecommended from "eslint-plugin-prettier/recommended";
 import simpleImportSort from "eslint-plugin-simple-import-sort";
 import eslintPluginUnicorn from "eslint-plugin-unicorn";
 import globals from "globals";
@@ -9,17 +11,13 @@ import tseslint from "typescript-eslint";
 import allowNullInOptionalParameter from "./eslint/allow-null-in-optional-parameter.js";
 import namingConvention from "./eslint/naming-convention.js";
 
-export default tseslint.config(
+export default defineConfig(
   eslint.configs.recommended,
-  // eslint-disable-next-line import/no-named-as-default-member
-  ...tseslint.configs.strict,
+  tseslint.configs.strict,
   importPlugin.flatConfigs.recommended,
   importPlugin.flatConfigs.typescript,
   eslintPluginUnicorn.configs.recommended,
-  eslintPluginPrettierRecommended,
-  {
-    ignores: ["dist/**/*", "docs/**/*", "coverage/**/*", "playground/**/*"],
-  },
+  eslintConfigPrettier,
   {
     settings: {
       "import/resolver": {
@@ -45,7 +43,7 @@ export default tseslint.config(
       "unicorn/no-array-reduce": "off",
       "no-restricted-imports": [
         "error",
-        { paths: [{ name: "ws", message: "Use `isomophic-ws` instead." }] },
+        { paths: [{ name: "ws", message: "Use `isomorphic-ws` instead." }] },
       ],
     },
   },
@@ -107,4 +105,5 @@ export default tseslint.config(
       "unicorn/no-process-exit": "off",
     },
   },
+  globalIgnores(["dist/**/*", "docs/**/*", "coverage/**/*", "playground/**/*"]),
 );
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -40,9 +40,9 @@
     "test:typecheck": "tsc --project tsconfig.test.json",
     "test:unit": "vitest --project unit",
     "test:e2e": "vitest --project e2e",
-    "lint": "npm-run-all lint:*",
-    "lint:eslint": "eslint --report-unused-disable-directives --cache",
-    "lint:spellcheck": "cspell --quiet '{src,test,test-utils}/**/*.{ts,tsx,js,json,md}'",
+    "lint": "eslint --report-unused-disable-directives --cache",
+    "spellcheck": "cspell --quiet --gitignore './**/*.{ts,js}'",
+    "format": "prettier './**/*.{ts,js}' --check",
     "build": "npm-run-all build:* && tsconfig-to-dual-package tsconfig.esm.json tsconfig.cjs.json",
     "build:esm": "tsc --project tsconfig.esm.json",
     "build:cjs": "tsc --project tsconfig.cjs.json",
@@ -71,7 +71,6 @@
     "eslint-config-prettier": "^10.1.8",
     "eslint-import-resolver-typescript": "^4.4.4",
     "eslint-plugin-import": "^2.31.0",
-    "eslint-plugin-prettier": "^5.5.4",
     "eslint-plugin-simple-import-sort": "^12.1.1",
     "eslint-plugin-unicorn": "^61.0.2",
     "get-port": "^7.1.0",
diff --git a/src/adapters/action/dispatcher-http.ts b/src/adapters/action/dispatcher-http.ts
diff --git a/src/mastodon/paginator.ts b/src/mastodon/paginator.ts

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,3 @@`
`1`	`1`	`{`
`2`		`- "recommendations": [`
`3`		`- "esbenp.prettier-vscode",`
`4`		`- "dbaeumer.vscode-eslint"`
`5`		`- ]`
	`2`	`+ "recommendations": ["esbenp.prettier-vscode", "dbaeumer.vscode-eslint"]`
`6`	`3`	`}`